lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] um: fix a build error
On Tue, Jul 22, 2008 at 11:53:54AM +0100, Alan Cox wrote:
>> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>>
>> --- linux-2.6/arch/um/drivers/line.c.orig 2008-07-22 12:06:17.000000000 +0200
>> +++ linux-2.6/arch/um/drivers/line.c 2008-07-22 12:06:49.000000000 +0200
>> @@ -362,10 +362,8 @@ static irqreturn_t line_write_interrupt(
>> if (tty == NULL)
>> return IRQ_NONE;
>>
>> - if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
>> - (tty->ldisc.write_wakeup != NULL))
>> - (tty->ldisc.write_wakeup)(tty);
>> -
>> + if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
>> + tty_wakeup(tty);
>
>Sorry I should have been clearer - you don't want the test_bit either.
>

Sure, tty_wakeup() already does that test.

And, tty_wakeup() also does wake_up_interruptible(), so I think
the wake_up_interruptible() below can also be removed, probably.

Thanks.

--
The opposite of love is not hate, but indifference.
--Elie Wiesel


\
 
 \ /
  Last update: 2008-07-22 13:29    [W:0.200 / U:0.236 seconds]
©2003-2011 Jasper Spaans. Advertise on this site