Messages in this thread | | | Date | Sun, 20 Jul 2008 14:33:02 -0700 | From | Arjan van de Ven <> | Subject | Re: [patch 3/4] fastboot: make the raid autodetect code wait for all devices to init |
| |
On Mon, 21 Jul 2008 14:30:12 +1000 Neil Brown <neilb@suse.de> wrote:
> > > + while (driver_probe_done()) > > msleep(100); > > That's worse. Now it really looks like a boolean that is being used > wrongly. It seems that driver_probe_done either returns 0 or -EBUSY, > so I'd prefer > > > + while (driver_probe_done() < 0) > > msleep(100); > > or even
ok I've done this one.
I'll be the first to say that this driver_probe_done() isn't very elegant.. but it's out of my current scope to rewrite that whole thing ... I'll leave that to GregKH.
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |