Messages in this thread Patch in this message | | | Date | Mon, 21 Jul 2008 09:58:30 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 5/7] drivers/scsi/scsi_scan.c: Release mutex in error handling code |
| |
From: Julia Lawall <julia@diku.dk>
The mutex is released on a successful return, so it would seem that it should be released on an error return as well.
The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl> @@ expression l; @@
mutex_lock(l); ... when != mutex_unlock(l) when any when strict ( if (...) { ... when != mutex_unlock(l) + mutex_unlock(l); return ...; } | mutex_unlock(l); ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- diff -u -p a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1760,6 +1760,7 @@ static void scsi_finish_async_scan(struc printk("%s called twice for host %d", __FUNCTION__, shost->host_no); dump_stack(); + mutex_unlock(&shost->scan_mutex); return; }
| |