Messages in this thread Patch in this message | | | Date | Mon, 21 Jul 2008 09:57:04 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 1/7] drivers/infiniband: Release mutex in error handling code |
| |
From: Julia Lawall <julia@diku.dk>
The mutex is released on a successful return, so it would seem that it should be released on an error return as well.
The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl> @@ expression l; @@
mutex_lock(l); ... when != mutex_unlock(l) when any when strict ( if (...) { ... when != mutex_unlock(l) + mutex_unlock(l); return ...; } | mutex_unlock(l); ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- diff -u -p a/drivers/infiniband/hw/ehca/ipz_pt_fn.c b/drivers/infiniband/hw/ehca/ipz_pt_fn.c --- a/drivers/infiniband/hw/ehca/ipz_pt_fn.c +++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.c @@ -163,6 +163,7 @@ static int alloc_small_queue_page(struct out: ehca_err(pd->ib_pd.device, "failed to allocate small queue page"); + mutex_unlock(&pd->lock); return 0; }
| |