lkml.org 
[lkml]   [2008]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
On Wed, Jul 16, 2008 at 05:57:45PM -0400, Dave Jones wrote:
> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
> > On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> > > If we don't enable FS_ENET we get build issues:
> > >
> > > arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> > > arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> > > arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
> >
> > How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>
> If CONFIG_PHYLIB=m however, that doesn't make any difference, because
> vmlinuz is trying to use a symbol which now lives in a module.

Yuck. If FOO selects BAR, and FOO is 'y', then BAR should be 'y', not 'm'.
If BAR depends on other symbols that are 'm', they should be changed to 'y'.

-Scott


\
 
 \ /
  Last update: 2008-07-21 18:17    [W:0.065 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site