lkml.org 
[lkml]   [2008]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: iommu fix potential overflow in alloc_iommu()


FUJITA Tomonori wrote:
> On Mon, 21 Jul 2008 10:15:22 -0400
> Prarit Bhargava <prarit@redhat.com> wrote:
>
>
>> (This didn't appear on LKML or any of the mirrors ... trying again)
>>
>> It is possible that alloc_iommu()'s boundary_size overflows as
>> dma_get_seg_boundary can return 0xffffffff. In that case, further usage of
>> boundary_size triggers a BUG_ON() in the iommu code.
>>
>
> Did you actually hit this? pci-gart_64.c is used only by X86_64.
>

I hit this by declaring a device struct and not declaring a value for
dev->dma_parms->segment_boundary_mask.

I was attempting to alloc out of the IOMMU and the code then dies on the
bugcheck in iommu_is_span_boundary() because boundary_size = 0.

P.


\
 
 \ /
  Last update: 2008-07-21 17:25    [from the cache]
©2003-2011 Jasper Spaans