[lkml]   [2008]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] iwlwifi: compilation error when CONFIG_IWLWIFI_DEBUG is not set
    From: Denis V. Lunev <>

    CC [M] drivers/net/wireless/iwlwifi/iwl-rfkill.o
    drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
    drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
    drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
    drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)

    The problem is that led_type_str is defined under CONFIG_IWLWIFI_DEBUG
    while IWL_DEBUG is a static inline function in this case. Replace it
    with macro.

    Signed-off-by: Denis V. Lunev <>
    Signed-off-by: Tomas Winkler <>
    drivers/net/wireless/iwlwifi/iwl-debug.h | 8 ++------
    1 files changed, 2 insertions(+), 6 deletions(-)

    diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
    index 097a72f..b4ffd33 100644
    --- a/drivers/net/wireless/iwlwifi/iwl-debug.h
    +++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
    @@ -68,12 +68,8 @@ void iwl_dbgfs_unregister(struct iwl_priv *priv);

    -static inline void IWL_DEBUG(int level, const char *fmt, ...)
    -static inline void IWL_DEBUG_LIMIT(int level, const char *fmt, ...)
    +#define IWL_DEBUG(level, fmt, args...)
    +#define IWL_DEBUG_LIMIT(level, fmt, args...)
    #endif /* CONFIG_IWLWIFI_DEBUG */

    Intel Israel (74) Limited
    This e-mail and any attachments may contain confidential material for
    the sole use of the intended recipient(s). Any review or distribution
    by others is strictly prohibited. If you are not the intended
    recipient, please contact the sender and delete all copies.

     \ /
      Last update: 2008-07-21 14:15    [W:0.022 / U:1.340 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site