[lkml]   [2008]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [GIT]: Networking
    From: Linus Torvalds <>
    Date: Sun, 20 Jul 2008 18:07:28 -0700 (PDT)

    > This warning also seems to be new:
    > net/ipv6/addrconf.c: In function ‘addrconf_add_linklocal’:
    > net/ipv6/addrconf.c:2318: warning: unused variable ‘net’
    > and looking at the code it's apparently because I'm not an optimistic
    > enough dad.
    > But hey, if you had three pre-teenage girls, you might not be all that
    > optimistic either. So I think that's reasonable.
    > Problem seems to have been introduced by 53b7997f ("ipv6 netns: Make
    > several "global" sysctl variables namespace aware")

    Let's just expand the thing in the one spot it gets
    referenced in.

    Please apply, thanks.

    ipv6: Fix warning in addrconf code.

    Reported by Linus.

    Signed-off-by: David S. Miller <>

    diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
    index 580ae50..9f4fcce 100644
    --- a/net/ipv6/addrconf.c
    +++ b/net/ipv6/addrconf.c
    @@ -2315,12 +2315,11 @@ static void init_loopback(struct net_device *dev)
    static void addrconf_add_linklocal(struct inet6_dev *idev, struct in6_addr *addr)
    struct inet6_ifaddr * ifp;
    - struct net *net = dev_net(idev->dev);
    u32 addr_flags = IFA_F_PERMANENT;

    if (idev->cnf.optimistic_dad &&
    - !net->ipv6.devconf_all->forwarding)
    + !dev_net(idev->dev)->ipv6.devconf_all->forwarding)
    addr_flags |= IFA_F_OPTIMISTIC;
     \ /
      Last update: 2008-07-21 03:19    [W:0.019 / U:12.612 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site