lkml.org 
[lkml]   [2008]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] cpusets: restructure the function update_cpumask() and update_nodemask()
    On Mon, 02 Jun 2008 16:31:05 +0800 Miao Xie <miaox@cn.fujitsu.com> wrote:

    > extract two functions from update_cpumask() and update_nodemask().They will be
    > used later for updating tasks' cpus_allowed and mems_allowed after CPU/NODE
    > offline/online.
    >
    > Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
    > Acked-by: Paul Jackson <pj@sgi.com>

    This patch has problems.

    kernel/cpuset.c: In function 'cpuset_write_resmask':
    kernel/cpuset.c:1374: warning: passing argument 2 of 'update_nodemask' discards qualifiers from pointer target type

    Did you not get this warning also?

    I don't know how to fix it. cftype.write_string() requires a const
    char* in the third arg, but we then go on to call update_nodemask(),
    which does a strstrip() on this allegedly-const char array.

    Taking a copy of the string in update_nodemask() would fix things, but
    that's pretty lame.



    \
     
     \ /
      Last update: 2008-07-02 11:21    [W:0.023 / U:29.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site