![]() | |||||||||||||
Messages in this thread |
Paul Menage wrote: > On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf@cn.fujitsu.com> wrote: >> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy': >> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN' >>>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> > > Acked-by: Paul Menage <menage@google.com> > > Thanks - what architecture did it break on? > On my x86_32. I guess this break has something to do with: http://marc.info/?l=linux-mm&m=121389282702302&w=2 ([PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit) You tested the patch before that patch was accepted by Andrew. > Paul> >> --->>>> should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch >>>> --- linux-mm/kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 >> +++ linux-mm/kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 >> @@ -13,6 +13,7 @@>> #include <linux/slab.h> >> #include <linux/res_counter.h> >> #include <linux/uaccess.h> >> +#include <linux/mm.h> >> >> void res_counter_init(struct res_counter *counter) >> { >>> > | ||||||||||||
| Last update: 2008-07-02 08:55 [from the cache] ©2003-2008 | |||||||||||||