Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH] PCI Hotplug: acpiphp: cleanup notify handler on all root bridges | Date | Wed, 2 Jul 2008 11:41:23 -0700 |
| |
On Tuesday, July 01, 2008 7:02 pm Alex Chiang wrote: > Hi Jesse, Kristen, > > During the development of the physical PCI slot patch series, > Gary Hade kept on reporting strange oopses due to interactions > between pci_slot and acpiphp. > > http://lkml.org/lkml/2007/11/28/319 > > He got busy and went away for a while, and that's when I was able > to sneak my patchset into Jesse's linux-next branch. ;) > > Recently, Gary got some time to test again on his x3950 M2 > system, and together, we finally figured out the oops. > > This bug has always been present in acpiphp so it's not a > regression. So if you want to hold off until the next merge > window, I'm ok with that. > > Otherwise, I feel it's pretty low-risk and could go into the next > -rc. Totally your call, I have no strong feelings either way.
given that it fixes some pretty bad behavior, I went ahead and pushed this into my pull request for Linus. Thanks for cleaning it up, the hotplug code is looking much better these days thanks to yours and Kenji-san's efforts.
Jesse
| |