Messages in this thread | | | Date | Wed, 2 Jul 2008 21:16:38 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCHv2 6/7] x86: traps_xx: modify default_do_nmi |
| |
[Alexander van Heukelum - Wed, Jul 02, 2008 at 06:39:01PM +0200] | - local caching of smp_processor_id() in default_do_nmi() | - v2: do not split default_do_nmi over two lines | | Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm> | | --- | | On Wed, Jul 02, 2008 at 08:12:20PM +0400, Cyrill Gorcunov wrote: | > | -static notrace __kprobes void default_do_nmi(struct pt_regs *regs) | > | +static notrace __kprobes void | > | +default_do_nmi(struct pt_regs *regs) | > | [ ... ] | > | -asmlinkage notrace __kprobes void default_do_nmi(struct pt_regs *regs) | > | +asmlinkage notrace __kprobes void | > | +default_do_nmi(struct pt_regs *regs) | > | > Hi Alexander, good done, thanks! But why did you split default_do_nmi | > definition by two lines? I think it would be better to keep them as it | > was before, ie by a single line | > | > static notrace __kprobes void default_do_nmi(struct pt_regs *regs) | | Thanks! Here is the replacement patch with default_do_nmi left on | a single line. Patch 7 applies with 1 line fuzz. | | Greetings, | Alexander |
Thanks, Alexander, this looks good to me. Feel free to add my Signed-off if you need it.
- Cyrill -
| |