Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH] coredump: kill mm->core_done | Date | Sat, 19 Jul 2008 20:20:01 -0700 (PDT) |
| |
It is indeed ugly. I think the place to start is with moving all the coredump code out of exit_mm() into a new subfunction that is just passed the mm pointer, and doing the same with coredump_finish() as you've done, but leaving the completion logic inside those functions the same. If all references to the core_* fields in mm_struct are inside coredump_*() functions, then that is a good basis for the future cleanups.
Thanks, Roland
| |