Messages in this thread | | | Subject | Re: [linux-dvb] [PATCH] V4L: Link tuner before saa7134 | From | hermann pitton <> | Date | Sat, 19 Jul 2008 00:56:39 +0200 |
| |
Hi,
Am Freitag, den 18.07.2008, 12:51 +0100 schrieb Simon Arlott: > On Fri, July 18, 2008 12:28, Brian Marete wrote: > > On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote: > >> > >> #1 users can't set thetunertype anymore, > >> but the few cases oftunerdetection from eeprom we have should > >> work again for that price. > > > > Hello, > > > > Any patch yet for above issue? It seems to have made it into 2.6.26. > > > > I use saa7134 with everything, including the tuner modules, compiled > > as a module. My card is detected as a flyvideo2000. The default tuner > > for that card (#37) allows me to tune into TV but not to FM Radio. I > > can access both functions (TV and FM Radio) if I override with > > tuner=69, which is what I usually do. That override does not work on > > 2.6.26. > > > > Any suggestions? > > Modify saa7134_board_init2 so that the manual tuner type setting isn't > ignored. The first thing it does is to overwrite the current value > (set earlier from module parameter) with the static values... even > before trying to autodetect it. > > In saa7134-core.c saa7134_initdev: > dev->tuner_type = saa7134_boards[dev->board].tuner_type; > +dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > In saa7134-cards.c saa7134_board_init2: > -dev->tuner_type = saa7134_boards[dev->board].tuner_type; > -dev->tuner_addr = saa7134_boards[dev->board].tuner_addr; > > I think that will fix it. >
this restores tuner behavior on the saa7134 driver.
I can't test XCeive tuners, which load different firmware dynamically. Mauro was on them.
Please send the patch to Mauro and/or provide your signed-off-by.
This must go to the stable team ASAP as well.
Reviewed-by: Hermann Pitton <hermann-pitton@arcor.de>
Many thanks!
Cheers, Hermann
| |