Messages in this thread |  | | | Date | Fri, 18 Jul 2008 15:49:23 -0700 | | From | Suresh Siddha <> | | Subject | Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives |
| |
On Fri, Jul 18, 2008 at 03:42:17PM -0700, Zachary Amsden wrote: > On Fri, 2008-07-18 at 15:02 -0700, Maciej W. Rozycki wrote: > > On Fri, 18 Jul 2008, Yinghai Lu wrote: > > > > > CC arch/x86/kernel/apic_64.o > > > arch/x86/kernel/apic_64.c:170: error: unknown field 'write_atomic' > > > specified in initializer > > > arch/x86/kernel/apic_64.c:170: error: 'native_apic_mem_write_atomic' > > > undeclared here (not in a function) > > > arch/x86/kernel/apic_64.c:209: error: unknown field 'write_atomic' > > > specified in initializer > > > arch/x86/kernel/apic_64.c:209: warning: initialization from > > > incompatible pointer type > > > make[1]: *** [arch/x86/kernel/apic_64.o] Error 1 > > > make: *** [arch/x86/kernel] Error 2 > > > > Just remove the offending initialisers. They are not needed anymore as > > the .write method is now used universally including places where > > .write_atomic was. I just could not stand watching the thing > > proliferate... > > Thank you for cleaning this up Yinghai, but this really begs the > question - is having write_atomic REALLY worthwhile?
And this thread is about, Maciej's cleanup patch which removed write_atomic completely :)
Thanks to Maciej who posted this fix. It was on my todo list for sometime now!
thanks, suresh
|  |