Messages in this thread | | | Date | Fri, 18 Jul 2008 23:36:22 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: Move dma32_reserve_bootmem() after reserve_crashkernel() |
| |
* Bernhard Walle <bwalle@suse.de> wrote:
> On a x86-64 machine (nothing special I could encounter) I had the > problem that crashkernel reservation with the usual "64M@16M" failed. > While debugging that, I encountered that dma32_reserve_bootmem() > reserves a memory region which is in that area. > > Because dma32_reserve_bootmem() does not rely on a specific offset but > crashkernel does, it makes sense to move the dma32_reserve_bootmem() > reservation down a bit. I tested that patch and it works without > problems. I don't see any negative effects of that move, but maybe I > oversaw something ... > > While we strictly don't need that patch in 2.6.27 because we have the > automatic, dynamic offset detection, it makes sense to also include it > here because: > > - it's easier to get it in -stable then, > - many people are still used to the 'crashkernel=...@16M' syntax, > - not everybody may be using a reloatable kernel.
applied to tip/x86/crashdump, thanks Bernhard.
Ingo
| |