Messages in this thread Patch in this message | | | Date | Fri, 18 Jul 2008 18:41:46 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 0/3] [x86] Configure out CPU-specific support code |
| |
* Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hi, > > The purpose of this small patch series is to be able to configure out > x86 CPU-specific support code, in order to reduce the kernel code > size, particularly for embedded systems. > > Reviews and comments welcome.
this interacted quite a bit with ongoing work in arch/x86. I have applied your first patch (it had some conflicts which i resolved.)
but much of #2 has already been done via:
| commit cc9f7a0ccf000d4db5fbdc7b0ae48eefea102f69 | Author: Yinghai Lu <yhlu.kernel@gmail.com> | Date: Mon Jun 16 16:11:08 2008 -0700 | | x86: kill bad_ppro
this is now upstream. Likewise, #3 doesnt apply either. So could you please rework #2 and #3 against tip/x86/cpu? You can pull it via the coordinates below.
Ingo
-------------> the latest x86/cpu git tree is at:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86/cpu
------------------> Thomas Petazzoni (1): x86: consolidate the definition of the force_mwait variable
arch/x86/kernel/cpu/amd.c | 2 -- arch/x86/kernel/process.c | 1 + include/asm-x86/processor.h | 2 -- 3 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 81a07ca..cae9cab 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -24,8 +24,6 @@ extern void vide(void); __asm__(".align 4\nvide: ret"); -int force_mwait __cpuinitdata; - static void __cpuinit early_init_amd(struct cpuinfo_x86 *c) { if (cpuid_eax(0x80000000) >= 0x80000007) { diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 4d629c6..74f2d19 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -15,6 +15,7 @@ unsigned long idle_nomwait; EXPORT_SYMBOL(idle_nomwait); struct kmem_cache *task_xstate_cachep; +static int force_mwait __cpuinitdata; int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src) { diff --git a/include/asm-x86/processor.h b/include/asm-x86/processor.h index 55402d2..15cb82a 100644 --- a/include/asm-x86/processor.h +++ b/include/asm-x86/processor.h @@ -722,8 +722,6 @@ static inline void __sti_mwait(unsigned long eax, unsigned long ecx) extern void mwait_idle_with_hints(unsigned long eax, unsigned long ecx); -extern int force_mwait; - extern void select_idle_routine(const struct cpuinfo_x86 *c); extern unsigned long boot_option_idle_override;
| |