Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] stopmachine: add stopmachine_timeout v2 | Date | Fri, 18 Jul 2008 14:18:09 +1000 |
| |
On Thursday 17 July 2008 13:40:14 Hidetoshi Seto wrote: > Jeremy Fitzhardinge wrote: > > Hidetoshi Seto wrote: > >> +#ifdef CONFIG_STOP_MACHINE > >> +extern unsigned long stopmachine_timeout; > >> +#endif > > > > No externs in C files. Put it in an appropriate header. > > sysctl.c already has many externs... but I can fix at least > the above.
I already patched this; checkpatch.pl warned about it :)
> > I'll do a proper review soon. > > Is it better to postpone v4 until your comment comes?
I think the only other real change is to make the value in ms, not seconds, and allow a 0 value to mean "don't check".
Cheers, Rusty.
| |