Messages in this thread |  | | | Subject | Re: [PATCH 01/23] tracehook: add linux/tracehook.h | | From | Petr Tesarik <> | | Date | Fri, 18 Jul 2008 13:57:00 +0200 | |
On Thu, 2008-07-17 at 09:34 -0400, Christoph Hellwig wrote:
> On Thu, Jul 17, 2008 at 12:48:18PM +0400, Alexey Dobriyan wrote:
> > > The new linux/ptrace.h inlines are used by the following patches in the
> > > new tracehook_*() inlines. Using these helpers for the ptrace event
> > > stops makes it simple to change or disable the old ptrace implementation
> > > of these stops conditionally later.
> >
> > Call them "utrace_*" from the start?
>
> Yes, please.
>
> > Pointless 1:1 wrapper unless you're going to #ifdef ->ptrace later.
>
> Even then I don't think it's a good idea. This one should only be
> touched in very very few places
So, do you suggest putting those #ifdef's in the middle of the function
which uses it? Anyway, this patch should probably be posted later, i.e.
when the other implementation is actually introduced.
My $0.02.
Petr
|  |