lkml.org 
[lkml]   [2008]   [Jul]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromRusty Russell <>
SubjectRe: [PATCH 1/8] cpumask: Replace cpumask_of_cpu with cpumask_of_cpu_ptr
DateFri, 18 Jul 2008 15:30:09 +1000
On Wednesday 16 July 2008 07:14:30 Mike Travis wrote:
>   * This patch replaces the dangerous lvalue version of cpumask_of_cpu
>     with new cpumask_of_cpu_ptr macros.  These are patterned after the
>     node_to_cpumask_ptr macros.

Hi Mike,

   Should we just put cpumask_of_cpu_map[] in generic code and then have 
cpumask_of_cpu() always return a cpumask_t pointer?  These macros which 
declare things which may be one of two types is a real penalty for code 
readability.

Thanks,
Rusty.


\
 
 \ /
  Last update: 2008-07-18 07:33    [from the cache]
©2003-2008