Messages in this thread | | | Date | Fri, 18 Jul 2008 13:36:15 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/4] x86_64 ia32 syscall audit fast-path |
| |
* Roland McGrath <roland@redhat.com> wrote:
> I don't know if there was some reason I did it that way rather than > the other. I don't remember in which order I wrote and rewrote the > patches. I'll cop to laziness if you like. > > It reminded me that I'd never tested the AMD (syscall/sysret) version > of this path. That was clearly just plain lazy, and it was in fact > broken. It's a good thing you called me names and made me feel bad > about myself, so I cast about for more of my failings. > > This version of the patch changes what you didn't like, and it works > right on both the AMD (syscall) and Intel (sysenter) paths. (Yes, I > had already tested all the other paths. This is the only one that is > not used on Intel hardware.)
do you have a delta patch against tip/x86/audit-speedup by any chance? That is a topic branch of your previous drop, which got tested as well to a certain degree. Would make it easier to see what changed, would make the merge have a more nuanced history, etc.
or, alternatively, if you have a -git based branch that i could pull, that would be nice as well. (i can compare old-x86/audit-speedup to new-x86/audit-speedup.)
Ingo
| |