Messages in this thread |  | | | Date | Thu, 17 Jul 2008 14:54:34 +0900 | | From | Paul Mundt <> | | Subject | Re: [2.6 patch] fix sh ptep_get_and_clear breakage | |
On Wed, Jul 16, 2008 at 07:45:40PM +0300, Adrian Bunk wrote:
> Commit 1ea0704e0da65b2b46f9142ff1391163aac24060
> (mm: add a ptep_modify_prot transaction abstraction)
> triggered on sh build errors like the following:
>
> <-- snip -->
>
> ...
> CC arch/sh/mm/pg-sh4.o
> cc1: warnings being treated as errors
> include2/asm/pgtable.h:139: error: 'ptep_get_and_clear' declared inline after being called
> include2/asm/pgtable.h:139: error: previous declaration of 'ptep_get_and_clear' was here
> make[2]: *** [arch/sh/mm/pg-sh4.o] Error 1
>
> <-- snip -->
>
> Since there's no good reason for marking these global functions as
> "inline" this patch therefore removes the inline's.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Magnus already fixed this for pg-sh4, but the SH7705 implementation was
overlooked, so I applied your patch there. Thanks.
|  |