Messages in this thread | | | Date | Wed, 16 Jul 2008 19:56:54 +0200 | From | Louis Rilling <> | Subject | Re: [BUGFIX][PATCH v2 0/2] configfs: Fix cleanup after mkdir() failure |
| |
On Wed, Jul 16, 2008 at 10:27:03AM -0700, Joel Becker wrote: > On Wed, Jul 16, 2008 at 03:08:21PM +0200, Louis Rilling wrote: > > There is still a few things in flight: > > - error handling in config_*_init_type_name(): has rather low priority in my > > TODO list, will come back to it probably in a few weeks. > > I thought we did this already. Perhaps I didn't include it? > Did we have another change to make?
You requested me to move a BUG_ON() earlier (before the actual memory allocation), and to update documentation. I'm quite in a hurry on other things, so I'm delaying this (especially the documentation part for which I feel like a new paragraph is needed).
> > > - a small locking cleanup in configfs_rmdir(): will do at the same time as > > lockdep stuff. > > What sort of change? I suppose I'll see it when it arrives.
You may look at the retry loop in configfs_rmdir() and see that locks need only to be taken inside the loop, not outside. This would result in fewer lines for exactly the same behavior.
> I figure this new stuff will probably miss the .27 window, but > it sounds like that's fine - nothing too serious, and it will make .28.
Sorry for not being responsive enough. As mentioned above, I have more urgent things to work on right now.
Thanks,
Louis
-- Dr Louis Rilling Kerlabs Skype: louis.rilling Batiment Germanium Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de Coesmes http://www.kerlabs.com/ 35700 Rennes [unhandled content-type:application/pgp-signature] | |