Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH/RESEND] PCI:pciehp:remove unnecessary volatile in struct controller | Date | Wed, 16 Jul 2008 08:47:37 -0700 |
| |
On Wednesday, July 16, 2008 7:54 am tom.leiming@gmail.com wrote: > From: Ming Lei <tom.leiming@gmail.com> > > Proper memory barriers have been added to order accesses > to ->cmd_busy, so volatile declaration for cmd_busy can > be removed. > > Signed-off-by: Ming Lei <tom.leiming@gmail.com> > --- > drivers/pci/hotplug/pciehp.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h > index 79c9dda..5e2becd 100644 > --- a/drivers/pci/hotplug/pciehp.h > +++ b/drivers/pci/hotplug/pciehp.h > @@ -96,7 +96,7 @@ struct controller { > u32 slot_cap; > u8 cap_base; > struct timer_list poll_timer; > - volatile int cmd_busy; > + int cmd_busy; > unsigned int no_cmd_complete:1; > };
Yeah I saw the first one, just hadn't had a chance to reply/apply yet. I just applied it to my linux-next branch and pushed.
Jesse
| |