lkml.org 
[lkml]   [2008]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [SUGGESTION]: drop virtual merge accounting in I/O requests
On Tue, 15 Jul 2008, David Miller wrote:

> From: Mikulas Patocka <mpatocka@redhat.com>
> Date: Tue, 15 Jul 2008 18:32:37 -0400 (EDT)
>
> > On Mon, 14 Jul 2008, David Miller wrote:
> >
> > > From: Mikulas Patocka <mpatocka@redhat.com>
> > > Date: Mon, 14 Jul 2008 19:16:17 -0400 (EDT)
> > >
> > > > So the question is: to reduce number of requests by 12% on an outdated
> > > > SCSI card, it is sensible to maintain complicated merge accounting logic
> > > > in the core block layer? To me, it doesn't seem sensible.
> > >
> > > Rip out the code if you like, then. I really don't have time to
> > > work on this myself. So if you do, by all means do whatever
> > > you think is appropriate.
> >
> > So add signed-off line and forward it to Linus.
> >
> > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>
> I said remove code, not turn if off.

Removing the code from the block layer needs to be ACKed by block
maintainers --- and it can be done if it will be found that on
architectures that use it (alpha, pa-risc) it has no benefit. I believe
that it will eventually show up that there is little/no benefit from the
hw_segments accounting, but it will take some time.

This patch is a simple fix that can be done now to stop sparc64 from
crashing. (most other architectures also define it as 0 --- for the same
reason, they can't guarantee that the merge will happen).

> I guess you didn't like that option even though you seem heavily
> convinced that it buys us essentially nothing, and I'm even starting to
> agree with you.
>
> If the VMERGE code is going to stay, and it's a bug or a limitation in
> the sparc64 IOMMU code, I'd rather that get fixed.

So if it stays and if you find time to fix it, you can revert it back to
8192.

But until one of two possible solutions happen (removing the virtual merge
accounting or declaring that it must stay and fixing sparc64), the
simplest way to avoid crashes is to define BIO_VMERGE_BOUNDARY 0.

> I have FUJITA's excellent analysis of the sparc64 specific IOMMU issue
> in my inbox and I intend to have a look at it when I get a chance.

Mikulas


\
 
 \ /
  Last update: 2008-07-16 01:01    [from the cache]
©2003-2011 Jasper Spaans