lkml.org 
[lkml]   [2008]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 14/17] LTTng instrumentation - net
    Network device activity instrumentation (xmit/receive). Allows to detect when a
    packet had arrived on the network card or when it is going to be sent. This is
    the instrumentation point outside of the drivers that is the closest to the
    hardware. It allows to detect the amount of time taken by a packet to go through
    the kernel between the system call and the actual delivery to the network card
    (given that system calls are instrumented).

    Those tracepoints are used by LTTng.

    About the performance impact of tracepoints (which is comparable to markers),
    even without immediate values optimizations, tests done by Hideo Aoki on ia64
    show no regression. His test case was using hackbench on a kernel where
    scheduler instrumentation (about 5 events in code scheduler code) was added.
    See the "Tracepoints" patch header for performance result detail.

    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    CC: Andrew Morton <akpm@linux-foundation.org>
    CC: netdev@vger.kernel.org
    CC: Jeff Garzik <jgarzik@pobox.com>
    CC: Masami Hiramatsu <mhiramat@redhat.com>
    CC: 'Peter Zijlstra' <peterz@infradead.org>
    CC: "Frank Ch. Eigler" <fche@redhat.com>
    CC: 'Ingo Molnar' <mingo@elte.hu>
    CC: 'Hideo AOKI' <haoki@redhat.com>
    CC: Takashi Nishiie <t-nishiie@np.css.fujitsu.com>
    CC: 'Steven Rostedt' <rostedt@goodmis.org>
    CC: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
    ---
    include/trace/net.h | 14 ++++++++++++++
    net/core/dev.c | 3 +++
    2 files changed, 17 insertions(+)

    Index: linux-2.6-lttng/net/core/dev.c
    ===================================================================
    --- linux-2.6-lttng.orig/net/core/dev.c 2008-07-15 14:51:51.000000000 -0400
    +++ linux-2.6-lttng/net/core/dev.c 2008-07-15 15:15:59.000000000 -0400
    @@ -121,6 +121,7 @@
    #include <linux/ctype.h>
    #include <linux/if_arp.h>
    #include <linux/if_vlan.h>
    +#include <trace/net.h>

    #include "net-sysfs.h"

    @@ -1702,6 +1703,7 @@ int dev_queue_xmit(struct sk_buff *skb)
    }

    gso:
    + trace_net_dev_xmit(skb);
    txq = &dev->tx_queue;
    spin_lock_prefetch(&txq->lock);

    @@ -2107,6 +2109,7 @@ int netif_receive_skb(struct sk_buff *sk

    __get_cpu_var(netdev_rx_stat).total++;

    + trace_net_dev_receive(skb);
    skb_reset_network_header(skb);
    skb_reset_transport_header(skb);
    skb->mac_len = skb->network_header - skb->mac_header;
    Index: linux-2.6-lttng/include/trace/net.h
    ===================================================================
    --- /dev/null 1970-01-01 00:00:00.000000000 +0000
    +++ linux-2.6-lttng/include/trace/net.h 2008-07-15 15:14:54.000000000 -0400
    @@ -0,0 +1,14 @@
    +#ifndef _TRACE_NET_H
    +#define _TRACE_NET_H
    +
    +#include <net/sock.h>
    +#include <linux/tracepoint.h>
    +
    +DEFINE_TRACE(net_dev_xmit,
    + TPPROTO(struct sk_buff *skb),
    + TPARGS(skb));
    +DEFINE_TRACE(net_dev_receive,
    + TPPROTO(struct sk_buff *skb),
    + TPARGS(skb));
    +
    +#endif
    --
    Mathieu Desnoyers
    Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
    OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


    \
     
     \ /
      Last update: 2008-07-16 00:37    [W:0.025 / U:180.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site