lkml.org 
[lkml]   [2008]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] mm: fix ptep_modify_* for no-MMU systems
    Fixes build problem: 
    the functions added to asm-generic/pgtable.h are only used by
    mm/mprotect.c (a MMU-only file), but they were not added inside of the
    CONFIG_MMU ifdef block. since the functions rely on things inside of
    CONFIG_MMU (the lines just above in pgtable.h), we get build failure
    on all no-mmu setups:
    CC init/main.o
    In file included from include/asm/pgtable.h:94,
    from include/linux/mm.h:39,
    from include/asm/dma.h:39,
    from include/linux/bootmem.h:8,
    from init/main.c:27:
    include/asm-generic/pgtable.h: In function '__ptep_modify_prot_start':
    include/asm-generic/pgtable.h:210: error: implicit declaration of
    function 'ptep_get_and_clear'
    include/asm-generic/pgtable.h:210: error: incompatible types in return
    make[1]: *** [init/main.o] Error 1
    make: *** [init/main.o] Error 2

    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    Cc: Adrian Bunk <bunk@kernel.org>
    Cc: Mike Frysinger <vapier.adi@gmail.com>
    ---
    include/asm-generic/pgtable.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    ===================================================================
    --- a/include/asm-generic/pgtable.h
    +++ b/include/asm-generic/pgtable.h
    @@ -195,7 +195,6 @@
    }
    return 0;
    }
    -#endif /* CONFIG_MMU */

    static inline pte_t __ptep_modify_prot_start(struct mm_struct *mm,
    unsigned long addr,
    @@ -253,6 +252,7 @@
    __ptep_modify_prot_commit(mm, addr, ptep, pte);
    }
    #endif /* __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION */
    +#endif /* CONFIG_MMU */

    /*
    * A facility to provide lazy MMU batching. This allows PTE updates and




    \
     
     \ /
      Last update: 2008-07-15 22:47    [W:0.021 / U:95.812 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site