Messages in this thread Patch in this message | | | From | Avi Kivity <> | Subject | [PATCH 13/19] KVM: x86 emulator: Fix HLT instruction | Date | Tue, 15 Jul 2008 15:12:32 +0300 |
| |
From: Mohammed Gamal <m.gamal005@gmail.com>
This patch fixes issue encountered with HLT instruction under FreeDOS's HIMEM XMS Driver.
The HLT instruction jumped directly to the done label and skips updating the EIP value, therefore causing the guest to spin endlessly on the same instruction.
The patch changes the instruction so that it writes back the updated EIP value.
Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com> Signed-off-by: Avi Kivity <avi@qumranet.com> --- arch/x86/kvm/x86_emulate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 18ca25c..8bc63f6 100644 --- a/arch/x86/kvm/x86_emulate.c +++ b/arch/x86/kvm/x86_emulate.c @@ -1731,7 +1731,7 @@ special_insn: break; case 0xf4: /* hlt */ ctxt->vcpu->arch.halt_request = 1; - goto done; + break; case 0xf5: /* cmc */ /* complement carry flag from eflags reg */ ctxt->eflags ^= EFLG_CF; -- 1.5.6.1
| |