lkml.org 
[lkml]   [2008]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/17] ocfs2: Don't snprintf() without a format.
    Date
    From: Joel Becker <joel.becker@oracle.com>

    Some system files are per-slot. Their names include the slot number.
    ocfs2_sprintf_system_inode_name() uses the system inode definitions to
    fill in the slot number with snprintf().

    For global system files, there is no node number, and the name was
    printed as a format with no arguments. -Wformat-nonliteral and
    -Wformat-security don't like this. Instead, use a static "%s" format
    and the name as the argument.

    Signed-off-by: Joel Becker <joel.becker@oracle.com>
    ---
    fs/ocfs2/ocfs2_fs.h | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
    index 52c4266..3f19451 100644
    --- a/fs/ocfs2/ocfs2_fs.h
    +++ b/fs/ocfs2/ocfs2_fs.h
    @@ -901,7 +901,7 @@ static inline int ocfs2_sprintf_system_inode_name(char *buf, int len,
    * list has a copy per slot.
    */
    if (type <= OCFS2_LAST_GLOBAL_SYSTEM_INODE)
    - chars = snprintf(buf, len,
    + chars = snprintf(buf, len, "%s",
    ocfs2_system_inodes[type].si_name);
    else
    chars = snprintf(buf, len,
    --
    1.5.4.1


    \
     
     \ /
      Last update: 2008-07-15 00:07    [W:0.019 / U:32.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site