Messages in this thread | | | Date | Mon, 14 Jul 2008 14:33:57 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] ip2: avoid add_timer() with pending timer |
| |
On Mon, 14 Jul 2008 11:49:55 +0900 Akinobu Mita <akinobu.mita@gmail.com> wrote:
> add_timer() is not suppose to be called when the timer is pending. > ip2 driver attempts to avoid that condition by setting and resetting > a flag (TimerOn) in timer function. But there is some gap between > add_timer() and setting TimerOn. > > This patch fix this problem by using mod_timer() and remove TimerOn > which has been unnecessary by this change. > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > Cc: Michael H. Warfield <mhw@wittsend.com>
Acked-by: Alan Cox <alan@redhat.com>
Queued for ttydev tree
Alan
| |