lkml.org 
[lkml]   [2008]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 02/15] x86_64: Fold pda into per cpu area
Ingo Molnar wrote:
> * Eric W. Biederman <ebiederm@xmission.com> wrote:
...
>> Given that we have not yet understood the weird failure case. This patch needs
>> to be split in two.
>> - make the current per cpu variable section zero based.
>> - Move the pda into the per cpu variable section.
>>
>> There are too many variables at present the reported failure cases to
>> guess what is really going on.
>>
>> We can not optimize the per cpu variable accesses until the pda moves
>> but we can easily test for linker and tool chain bugs with zero
>> based pda segment itself.
>
> agreed, a patch of this gravity and with a diffstat:
>
> 12 files changed, 112 insertions(+), 142 deletions(-)
>
> is indeed too large. Test failures that get bisected to this patch will
> still cause people to guess about which aspect of the large patch caused
> the problem.
>
> Ingo

That split has been done and I've sent it to Jeremy and Peter for further
review.

Thanks,
Mike



\
 
 \ /
  Last update: 2008-07-14 16:27    [W:0.212 / U:0.064 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site