Messages in this thread | | | Date | Sun, 13 Jul 2008 17:51:30 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH] x86: let 32bit use apic_ops too |
| |
On Sun, 13 Jul 2008, Suresh Siddha wrote:
> So we should probably have native_apic_mem_write_around() and use that > in ack_APIC_irq() and for good apic it is native_apic_mem_write() > and for !CONFIG_X86_GOOD_APIC, it is native_apic_mem_write_atomic()
Why don't you simply define apic_write_around() correctly for your platform? -- for 64-bit it is always the same as apic_write() as X86_GOOD_APIC may only be cleared for the original Pentium processor, so any unnecessary code for the opposite case will be optimised away at the build time, whether you use a macro or an inline function. Why do you think you need to create more variations of this contraption which is a workaround for a corner-case hw erratum anyway?
Maciej
| |