lkml.org 
[lkml]   [2008]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
* Andrew Morton (akpm@linux-foundation.org) wrote:
> On Tue, 8 Jul 2008 23:02:01 -0400 Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
>
> > * Masami Hiramatsu (mhiramat@redhat.com) wrote:
> > > Introduce marker_entry_free_old() and check old pointer is NULL before
> > > setting call_rcu_sched(), because marker_entry_remove/add_probe() can
> > > return NULL.
> > >
> >
> > Hi Masami,
> >
> > I doubt this is a bug per se, because kfree accepts NULL pointers (and
> > kfree is the only action done on the oldptr by free_old_closure).
> >
> > This cleans up the code, so I think it's good to merge your patch, but I
> > would definitely not classify this as a bugfix.
> >
> > Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
>
> I cannot get this to apply on the rather dated tree which I have on this
> rather not-on-the-internet machine. Please merge this patch locally, test,
> rewrite the changelog and resend it to someone ;)
>

Hi Andrew,

As I pointed out in a reply to this email, I NACK this patch because it
removes a necessary quiescent state wait from the marker code. The other
reply here explains why I changed my mind about this patch.

http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-07/msg03514.html

Mathieu


--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


\
 
 \ /
  Last update: 2008-07-13 06:33    [W:0.202 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site