lkml.org 
[lkml]   [2008]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] regulator: TI bq24022 Li-Ion Charger driver
    From
    Date
    On Fri, 2008-07-11 at 12:16 -0700, Andrew Morton wrote:
    > On Thu, 10 Jul 2008 21:04:43 +0200 Philipp Zabel <philipp.zabel@gmail.com> wrote:
    >
    > > +/**
    > > + *bq24022_mach_info - platform data for bq24022
    > > + *@gpio_nce: GPIO line connected to the nCE pin,
    > > + * used to enable / disable charging.
    > > + *@gpio_iset2: GPIO line connected to the ISET2 pin,
    > > + * used to limit charging current to 100 mA / 500 mA.
    > > + */
    >
    > We normally have a space after the "*" in kerneldoc comments (some
    > weird people use a tab and waste space).
    >
    > I don't know whether the kerneldoc processors will correctly handle
    > the above. I guess I'll fix it so we don't find out.
    >
    > Also, I _think_ that kerneldoc will barf over the multi-line parameter
    > descriptions. I'll join those lines.
    >
    > --- a/include/linux/regulator/bq24022.h~regulator-ti-bq24022-li-ion-charger-driver-fix
    > +++ a/include/linux/regulator/bq24022.h
    > @@ -11,11 +11,9 @@
    > */
    >
    > /**
    > - *bq24022_mach_info - platform data for bq24022
    > - *@gpio_nce: GPIO line connected to the nCE pin,
    > - * used to enable / disable charging.
    > - *@gpio_iset2: GPIO line connected to the ISET2 pin,
    > - * used to limit charging current to 100 mA / 500 mA.
    > + * bq24022_mach_info - platform data for bq24022
    > + * @gpio_nce: GPIO line connected to the nCE pin, used to enable / disable charging
    > + * @gpio_iset2: GPIO line connected to the ISET2 pin, used to limit charging current to 100 mA / 500 mA
    > */
    > struct bq24022_mach_info {
    > int gpio_nce;
    > _


    Applied (to regulator git).

    Thanks

    Liam



    \
     
     \ /
      Last update: 2008-07-12 15:37    [W:0.021 / U:185.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site