lkml.org 
[lkml]   [2008]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2] regulator: TI bq24022 Li-Ion Charger driver
On Fri, 11 Jul 2008 17:28:06 +0200 Philipp Zabel <philipp.zabel@gmail.com> wrote:

> This adds a regulator driver for the TI bq24022 Single-Chip
> Li-Ion Charger with its nCE and ISET2 pins connected to GPIOs.

Incremental diffs are so much better. It allowed us to see what you
changed. Two things:

a) re-broke the kerneldoc comments

b) this:

--- a/drivers/regulator/bq24022.c~regulator-ti-bq24022-li-ion-charger-driver-update
+++ a/drivers/regulator/bq24022.c
@@ -145,12 +145,12 @@ static struct platform_driver bq24022_dr
.remove = __devexit_p(bq24022_remove),
};

-static int __init bq24022_init()
+static int __init bq24022_init(void)
{
- platform_driver_probe(&bq24022_driver, bq24022_probe);
+ return platform_driver_probe(&bq24022_driver, bq24022_probe);
}

-static void __exit bq24022_exit()
+static void __exit bq24022_exit(void)
{
platform_driver_unregister(&bq24022_driver);
}


\
 
 \ /
  Last update: 2008-07-13 03:55    [W:0.089 / U:0.632 seconds]
©2003-2014 Jasper Spaans. Advertise on this site