Messages in this thread | | | Date | Fri, 11 Jul 2008 23:53:05 +0400 | From | Alexey Dobriyan <> | Subject | Re: + use-warn-in-fs-proc.patch added to -mm tree |
| |
On Fri, Jul 11, 2008 at 11:45:40AM -0700, akpm@linux-foundation.org wrote: > --- a/fs/proc/generic.c~use-warn-in-fs-proc > +++ a/fs/proc/generic.c > @@ -806,12 +806,9 @@ continue_removing: > if (S_ISDIR(de->mode)) > parent->nlink--; > de->nlink = 0; > - if (de->subdir) { > - printk(KERN_WARNING "%s: removing non-empty directory " > + WARN(de->subdir, KERN_WARNING "%s: removing non-empty directory " > "'%s/%s', leaking at least '%s'\n", __func__, > de->parent->name, de->name, de->subdir->name); > - WARN_ON(1); > - }
It would be nice to call it WARN_IF but OK anyway.
| |