[lkml]   [2008]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch 13/17] Use WARN() in drivers/base/
    On Tue, 8 Jul 2008 09:53:07 -0700 Arjan van de Ven <> wrote:

    > Signed-off-by: Arjan van de Ven <>Index: linux.trees.git/drivers/base/core.c

    A number of these patches had mangled signed-off-by: lines.

    Please try to be consistent in the presence and placement of the ^--- line
    at the end of the changelog.

    I verified that all three copies of "Use WARN() in fs/" were the same.

    I've decided that I don't like the whole thing :( This:

    #define WARN(condition, format...) ({ \
    int __ret_warn_on = !!(condition); \
    if (unlikely(__ret_warn_on)) \
    __WARN_printf(format); \
    unlikely(__ret_warn_on); \

    is not a WARN(). It is a WARN_ON() function. The use of this name now leaves
    us no sensible name under which to implement

    #define WARN(format...)

     \ /
      Last update: 2008-07-11 21:27    [W:0.020 / U:43.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site