lkml.org 
[lkml]   [2008]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] init/version.c: Silenced sparse warning by declaring the version string.
    On Tue, 08 Jul 2008 14:21:09 -0700 Daniel Guilak <guilak@linux.vnet.ibm.com> wrote:

    > Signed-off-by: Daniel Guilak <daniel@danielguilak.com>

    Please always quote the warning or error message in the changelog when
    fixing it. Although it's pretty obvious in this case.

    > init/version.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/init/version.c b/init/version.c
    > index 9d17d70..041fd82 100644
    > --- a/init/version.c
    > +++ b/init/version.c
    > @@ -16,6 +16,7 @@
    > #define version(a) Version_ ## a
    > #define version_string(a) version(a)
    >
    > +extern int version_string(LINUX_VERSION_CODE);
    > int version_string(LINUX_VERSION_CODE);
    >
    > struct uts_namespace init_uts_ns = {

    hrm, what does this thing do? Seems to define

    int Version_132634;

    Then sticks that in the symbol table (and wastes a bit of bss).

    Does anything use it?

    Could it be made static?




    \
     
     \ /
      Last update: 2008-07-11 21:25    [W:0.021 / U:59.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site