Messages in this thread Patch in this message | | | From | "Luck, Tony" <> | Date | Fri, 11 Jul 2008 09:20:53 -0700 | Subject | RE: [PATCH] Fix ia64 simserial.c for Ldisc revamp |
| |
> How does this look instead
@@ -490,12 +460,6 @@ static void rs_set_termios(struct tty_struct *tty, struct ktermios *old_termios) { unsigned int cflag = tty->termios->c_cflag;
- if ( (cflag == old_termios->c_cflag) - && ( RELEVANT_IFLAG(tty->termios->c_iflag) - == RELEVANT_IFLAG(old_termios->c_iflag))) - return;
Since you deleted the only use of "cflag" in this function, you can delete the declaration too.
@@ -623,9 +587,8 @@ static void rs_close(struct tty_struct *tty, struct file * filp) * the line discipline to only process XON/XOFF characters. */ shutdown(info); - if (tty->ops->flush_buffer) - tty->ops->flush_buffer(tty); - if (tty->ldisc.flush_buffer) tty->ldisc.flush_buffer(tty); + rs_flush_buffer(tty); + tty_ldisc_flush(tty)
A ';' on the end of this line would make the compiler much happier :-)
With these two additions it looks great. Thanks
-Tony
| |