lkml.org 
[lkml]   [2008]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/16] AMD IOMMU: remove unneeded initializations from command buffer allocation
    Date
    This patch removes an unneeded initialization from the alloc_command_buffer
    function and replaces a memset with __GFP_ZERO.

    Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    ---
    arch/x86/kernel/amd_iommu_init.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
    index 0f5a911..0124995 100644
    --- a/arch/x86/kernel/amd_iommu_init.c
    +++ b/arch/x86/kernel/amd_iommu_init.c
    @@ -394,17 +394,15 @@ static int __init find_last_devid_acpi(struct acpi_table_header *table)
    */
    static u8 * __init alloc_command_buffer(struct amd_iommu *iommu)
    {
    - u8 *cmd_buf = (u8 *)__get_free_pages(GFP_KERNEL,
    + u8 *cmd_buf = (u8 *)__get_free_pages(GFP_KERNEL | __GFP_ZERO,
    get_order(CMD_BUFFER_SIZE));
    - u64 entry = 0;
    + u64 entry;

    if (cmd_buf == NULL)
    return NULL;

    iommu->cmd_buf_size = CMD_BUFFER_SIZE;

    - memset(cmd_buf, 0, CMD_BUFFER_SIZE);
    -
    entry = (u64)virt_to_phys(cmd_buf);
    entry |= MMIO_CMD_SIZE_512;
    memcpy_toio(iommu->mmio_base + MMIO_CMD_BUF_OFFSET,
    --
    1.5.3.7



    \
     
     \ /
      Last update: 2008-07-11 17:19    [W:0.024 / U:0.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site