lkml.org 
[lkml]   [2008]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dsp56k: use request_firmware
From
Date
On Thu, 2008-07-10 at 09:38 +0200, Fredrik Noring wrote:
> Hi David,
>
> 9 jul 2008 kl. 15.05 skrev David Woodhouse:
> > It is in fact identical. Disassembly with the tools found on
> > sourceforge
> > was fun, since they have endianness bugs, don't recognise the 'JMP'
> > which was the first instruction, and need each 3-byte instruction in
> > the
> > binary to be prefixed with a zero byte to make it 4 bytes. But after
> > sorting that out and going through it instruction by instruction, it
> > really does seem to match.
>
> Heh. Amazing.
>
> [ I think the code can be simplified: It currently copies itself to a
> high program memory location, but this is not necessary because DSP
> soft reset was never implemented (the reset would have been trapped by
> the code, in order to load a new program). The driver instead power-
> cycles the DSP every time a new program is loaded. ]

I did wonder about that. But since we can't test, we're not going to
touch. Better to keep the assembler code which precisely matches the
known-good binary.

--
dwmw2



\
 
 \ /
  Last update: 2008-07-10 10:57    [W:0.181 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site