Messages in this thread | | | Date | Thu, 10 Jul 2008 01:28:07 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2] handle failure of irqchip->set_type in setup_irq |
| |
On Thu, 10 Jul 2008 10:23:36 +0200 Uwe Kleine-K__nig <Uwe.Kleine-Koenig@digi.com> wrote:
> Hello, > > Andrew Morton wrote: > > > > However I'm presently brewing up a plot to do this: > > > > > > > > printk("function name is %Ss\n", (unsigned long *)chip->set_type); > > > > > > > > which I think will work. We can also do > > > > > > > > printk("IP address is %Si\n", (unsigned long *)ip_address_buffer); > > > > > > > > to replace NIPQUAD. And similar printk extensions. > > > > > > > > Am still thinking about it though. > > > I assume the result is 0fe1ef24f7bd0020f29ffe287dfdb9ead33ca0b2? > > > > yup. > When I saw this commit I wondered that it was you who told me to think > about this but the commiter was Linus.
A long story. I rubbed a magic lantern ;)
> > > Should I send a new version using %pF or is it easier if you fix up the > > > patch? > > > > A new version would be nice, thanks. Or an incremental diff, but I can and > > will turn new versions into an incremental in the twinkle of an eye, so > > either is OK. > voila:
Thanks.
| |