lkml.org 
[lkml]   [2008]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_64: fix delayed signals


On Thu, 10 Jul 2008, Linus Torvalds wrote:
>
> So the x86-64 behaviour actually matches what the x86-32 behavior was at
> the time before things split.
>
> And I'd also like to point out another commit, namely "[PATCH] fix broken
> vm86 interrupt/signal handling" (4031ff388138b58e5cd472dccce38828bcb8c706)
> that fixed a bug with an endless loop you had introduced in that original
> x86-32 code when you fixed this exact same issue back when.
>
> Heh. That's the kind of thing that worries me.

That said, seeing the full history of this same thing on the x86-32 side
actually makes me _much_ happier about the patch. Because now I can tell
when we did it, and what problems it seems to have caused (answer:
"apparently none that are possibly relevant on x86-64").

IOW, just seeing the fact that we used to behave the same, and then
changed it on the 32-bit side (with no apparent big issues) and did it
without updating the 64-bit side, makes me just much happier about your
patch. Just because I know know the background to why this was x86-64
only.

So now I'm considering just putting it in before the 2.6.26 release after
all ;)

Linus


\
 
 \ /
  Last update: 2008-07-11 04:07    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site