lkml.org 
[lkml]   [2008]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5] x86/pci: patches for tip/x86/unify-pci

    * Sam Ravnborg <sam@ravnborg.org> wrote:

    > On Thu, Jul 10, 2008 at 08:12:34PM +0200, Ingo Molnar wrote:
    > >
    > > * Ingo Molnar <mingo@elte.hu> wrote:
    > >
    > > > * Robert Richter <robert.richter@amd.com> wrote:
    > > >
    > > > > This patch series contains patches for tip/x86/unify-pci. It fixes
    > > > > NUMA initialization code reflecting latest changes in tip/master.
    > > > > Also there are build fixes and minor cleanups. Patch #5 is a cherry
    > > > > pick that fixes build on UP systems. Code reboots for smp/nosmp,
    > > > > acpi/noacpi, numaq, 32/64bit. It compiles for visws.
    > > >
    > > > thanks Robert. Today i've eliminated the VISWS subarch which greatly
    > > > simplified your series. I've picked up these two fixes:
    > > >
    > > > Robert Richter (2):
    > > > x86/pci merge: fixing numaq initialization
    > > > x86/pci: fix warnings in subsys_initcall functions
    > >
    > > btw., this is how arch/x86/pci/Makefile looks like now in tip/master:
    > >
    > > ----------------------------------------->
    > > pci-y := fixup.o
    > > pci-$(CONFIG_ACPI) += acpi.o
    > > pci-y += legacy.o irq.o
    > >
    > > pci-$(CONFIG_X86_VISWS) += visws.o
    > >
    > > pci-$(CONFIG_X86_NUMAQ) += numa.o
    > >
    > > obj-y += $(pci-y) common.o early.o
    > > obj-y += amd_bus.o
    > > <-----------------------------------------
    >
    > So if I am not mistaken you can kill pci-y entirely:
    >
    > obj-y := fixup.o
    > obj-$(CONFIG_ACPI) += acpi.o
    > obj-y += legacy.o irq.o
    >
    > obj-$(CONFIG_X86_VISWS) += visws.o
    >
    > obj-$(CONFIG_X86_NUMAQ) += numa.o
    >
    > obj-y += common.o early.o
    > obj-y += amd_bus.o

    ah, indeed :-) Very nice.

    Ingo


    \
     
     \ /
      Last update: 2008-07-10 21:57    [W:0.026 / U:32.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site