lkml.org 
[lkml]   [2008]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 14/34] AMD IOMMU: clue initialization code together
    On Thu, Jul 10, 2008 at 06:03:51AM -0700, Andrew Morton wrote:
    > On Thu, 10 Jul 2008 14:37:47 +0200 Joerg Roedel <joerg.roedel@amd.com> wrote:
    >
    > > > Is there a reason for using __get_free_pages() in this manner everywhere?
    > > > kmalloc() or kzalloc() are unsuitable?
    > >
    > > Yes. The device table has to be page aligned and has a maximum size of
    > > 2 MB.
    >
    > OK
    >
    > > > > + if (amd_iommu_dev_table == NULL)
    > > > > + goto out;
    > > > > +
    > > > > + /*
    > > > > + * Alias table - map PCI Bus/Dev/Func to Bus/Dev/Func the
    > > > > + * IOMMU see for that device
    > > > > + */
    > > > > + amd_iommu_alias_table = (void *)__get_free_pages(GFP_KERNEL,
    > > > > + get_order(alias_table_size));
    > >
    > > Hmm, maybe this table will fit into a kmalloc allocation. Its maximum
    > > size is 128 kb.
    >
    > Might as well keep it all consistent in that case.

    Yeah ok, I agree. Thanks for your review and comments. I try to push out
    the updates today.

    Joerg

    --
    | AMD Saxony Limited Liability Company & Co. KG
    Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
    System | Register Court Dresden: HRA 4896
    Research | General Partner authorized to represent:
    Center | AMD Saxony LLC (Wilmington, Delaware, US)
    | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


    \
     
     \ /
      Last update: 2008-07-10 15:39    [W:0.201 / U:0.264 seconds]
    ©2003-2014 Jasper Spaans. Advertise on this site