lkml.org 
[lkml]   [2008]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] (resend) reuse xxx_fifo_fops for xxx_pipe_fops
On Tue, Jul 01, 2008 at 01:10:45AM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2008 12:03:50 +0200 Denys Vlasenko <vda.linux@googlemail.com> wrote:
>
> > I think since XXX_pipe_fops are only used in this file,
> > just explaining this in the comment would be enough.
>
> no, a comment is only needed when the code is unobvious. Make
> the code obvious and we don't need a comment.
>
> As Christoph pointed out, open-coding shared_read_fops everywhere
> might make sense too. It'd make it harder to unshare them later
> on, but that's pretty improbable.

Deny's latest patch doesn't have the #defines anymore and looks quite
reasonable to me. If you really insist on magic naming I think shared
is a very bad choice because it doesn't have any useful meaning in this
context. If you insist on magic naming do _pipefifo_, but I think
the current version with the comment is much better.


\
 
 \ /
  Last update: 2008-07-01 10:19    [W:0.330 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site