Messages in this thread |  | | | From | OGAWA Hirofumi <> | | Subject | Re: [PATCH 4/7] fat: cleanup fs/fat/dir.c | | Date | Tue, 01 Jul 2008 23:16:11 +0900 |
| |
Christoph Hellwig <hch@infradead.org> writes:
> On Tue, Jul 01, 2008 at 11:57:03AM +0900, OGAWA Hirofumi wrote: >> >> This is no logic changes, just cleans fs/fat/dir.c up. > > I don't think it makes sense to mark the new functions inline, they are > quite big, and if it really makes sense to inline them the compiler will > do it for us.
I know people hate inline, me too recently. But, I also know old gcc is not smart. Actually the optimize by hand was much faster (although it's not kernel).
I've tested this without inline. gcc-3.4.6 doesn't inlined fat_name_match(), but gcc-4.3.1 inlined it.
What do you think? If you still think it shouldn't, I'll remove it. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
|  |