lkml.org 
[lkml]   [2008]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [stable] [patch 21/50] brd: dont show ramdisks in /proc/partitions
Chris Wright wrote:
> * H. Peter Anvin (hpa@kernel.org) wrote:
>> This seems a bit like cargo cult programming to me. If there isn't a
>> known, good, reason to revert this behaviour change, I would consider it
>> a bugfix, not a regression.
>
> We have one /proc/partitions parser that got broken (never saw details
> on how). I don't care for this change either (esp. since nbd is still
> left out...it's inconsistent).
>
> This is now the upstream behaviour (obvious since it's a -stable
> candidate), and the change was introduced in 2.6.25...I'd actually prefer
> to drop this patch, but there's no good reason to deviate if upstream
> keeps this one. I can defer while upstream gets revisited, can you
> revisit this upstream?

I had to ask Chris offline what he meant with this... basically, he and
I both agree that absent hard evidence of malfunction, we should revert
to 2.6.25 behaviour.

-hpa



\
 
 \ /
  Last update: 2008-06-09 22:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site