> case MOXA_GET_MAJOR:> + printk(KERN_WARNING "mxser: '%s' uses deprecated ioctl %x, fix "> + "your userspace\n", current->comm, cmd);Should be rate limited...Rest looks good, break change is definitely what is needed.Acked-by: Alan Cox <alan@redhat.com>