lkml.org 
[lkml]   [2008]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] drivers/input/tablet/gtco.c: eliminate early return
    From: Julia Lawall <julia@diku.dk>

    There seems to be no reason why this error case should do less cleaning up
    than the other adjacent ones, so the goto, which is currently dead code,
    seems to be what is intended.


    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---

    diff -u -p a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
    --- a/drivers/input/tablet/gtco.c
    +++ b/drivers/input/tablet/gtco.c
    @@ -863,7 +863,7 @@ static int gtco_probe(struct usb_interfa
    gtco->urbinfo = usb_alloc_urb(0, GFP_KERNEL);
    if (!gtco->urbinfo) {
    err("Failed to allocate URB");
    - return -ENOMEM;
    + error = -ENOMEM;
    goto err_free_buf;
    }


    \
     
     \ /
      Last update: 2008-06-08 15:01    [W:0.020 / U:60.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site